Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM] Test Capstone auto-sync #3399

Closed
wants to merge 15 commits into from
Closed

[ARM] Test Capstone auto-sync #3399

wants to merge 15 commits into from

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Feb 23, 2023

Do not merge

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This draft PR's only purpose is to test the new Capstone updater auto-sync.

Eventually more tests for the new instructions supported by Capstone will be added.

@Rot127 Rot127 added this to the 0.6.0 milestone Feb 23, 2023
@Rot127 Rot127 mentioned this pull request Feb 23, 2023
Merged
39 tasks
@Rot127 Rot127 changed the title Test Capstone auto-sync [ARM] Test Capstone auto-sync Feb 23, 2023
@XVilka

This comment was marked as resolved.

Sign in to view
@XVilka XVilka mentioned this pull request Apr 23, 2023
Closed
5 tasks
@XVilka
Copy link
Member

XVilka commented May 6, 2023

@Rot127 please rebase and update this PR since there were a lot of changes in your auto-sync since.

@Rot127 Rot127 force-pushed the dist-cs-auto-sync branch from 5c5f22f to 87bffaa Compare May 6, 2023 10:46
@Rot127
Copy link
Member Author

Rot127 commented May 6, 2023 •
edited
Loading

@XVilka So the build works now. Still a lot of tests are fail because of:

  • Missing register name aliases (fp etc.)
  • Some assertions.

I tested one or two assertions and they do not happen with cstool -d. So it is probably because the memory operands now includes offset registers and immediates which were prior auto-sync their own operands.
So Rizin likely passes a wrong operand to getRegName() and hits an assertion.

@XVilka XVilka mentioned this pull request May 9, 2023
Closed
@XVilka XVilka modified the milestones: 0.6.0, 0.7.0 Jun 9, 2023
@Rot127
Copy link
Member Author

Rot127 commented Jun 19, 2023 •
edited
Loading

Superseded by #3591

@Rot127 Rot127 closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio Awaiting requested review from wargio wargio will be requested when the pull request is marked ready for review wargio is a code owner

@XVilka XVilka Awaiting requested review from XVilka XVilka will be requested when the pull request is marked ready for review XVilka is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy will be requested when the pull request is marked ready for review kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r will be requested when the pull request is marked ready for review thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc will be requested when the pull request is marked ready for review ret2libc is a code owner

Assignees
No one assigned
Labels
ARM capstone rz-test RzAnalysis
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Rot127 @XVilka